No lazy static regex #6654
Merged
No lazy static regex #6654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
This is blocking the sync, so I'm merging my self. This shouldn't have any impact on the lint behavior (no change in tests). @bors r+ |
|
📌 Commit 3874631 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
@flip1995 wait, but what is the source of |
|
Good question, to which I don't have an answer. We have some regex deps in ui-cargo and in clippy_dev, but not in any of the actual Clippy packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @llogiq
#6500
regex is unnecessary for this lint (#6500 (comment))
lazy_static is unnecessary. The std lazy feature should be used instead.
changelog: none